-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add circular genome view storybook #2522
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2522 +/- ##
=======================================
Coverage 61.09% 61.09%
=======================================
Files 543 543
Lines 25141 25141
Branches 5900 5900
=======================================
Hits 15361 15361
Misses 9457 9457
Partials 323 323 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Didn't @garrettjstevens make a start on something like this a while ago? What ended up happening to it?
7288942
to
6c3af2b
Compare
6c3af2b
to
4b8c6a7
Compare
This is based on the basic storybook I did, but I never added uploading or anything like this has. |
@garrettjstevens made the storybook for this already and exists on main, this PR essentially adds a github build step to make it so that this gets deployed to s3. it also adds a "getting started" mdx formatted page with some explainer text similar to the lgv storybook, and changes it so the "show code" shows something that users can see more easily in the storybook |
Follow up to #2508 to add circular view + adds storybook
Fixes #2462