Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circular genome view storybook #2522

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Add circular genome view storybook #2522

merged 3 commits into from
Nov 16, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 16, 2021

Follow up to #2508 to add circular view + adds storybook

Fixes #2462

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 16, 2021
@cmdcolin cmdcolin added documentation and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #2522 (4b8c6a7) into main (a7bca7d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2522   +/-   ##
=======================================
  Coverage   61.09%   61.09%           
=======================================
  Files         543      543           
  Lines       25141    25141           
  Branches     5900     5900           
=======================================
  Hits        15361    15361           
  Misses       9457     9457           
  Partials      323      323           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bca7d...4b8c6a7. Read the comment docs.

Copy link
Contributor

@rbuels rbuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Didn't @garrettjstevens make a start on something like this a while ago? What ended up happening to it?

.github/workflows/push.yml Outdated Show resolved Hide resolved
@garrettjstevens
Copy link
Collaborator

Looks good. Didn't @garrettjstevens make a start on something like this a while ago? What ended up happening to it?

This is based on the basic storybook I did, but I never added uploading or anything like this has.

@cmdcolin
Copy link
Collaborator Author

@garrettjstevens made the storybook for this already and exists on main, this PR essentially adds a github build step to make it so that this gets deployed to s3. it also adds a "getting started" mdx formatted page with some explainer text similar to the lgv storybook, and changes it so the "show code" shows something that users can see more easily in the storybook

@cmdcolin cmdcolin merged commit 0ad2a3d into main Nov 16, 2021
@cmdcolin cmdcolin deleted the cgv_storybook branch November 16, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add storybook upload for embedded circular view
3 participants