Fix broken feature layout due to async race condition on getRpcDriver #2551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix #2547
The summary of #2547 is that multiple rpc drivers were being created due to the async change of getDriver
This changes it back to not being an async call, but loses the storing of ipc call to userData with this
If it is needed to have userData for other purposes in the code, it could be obtained in another way?
Alternatively, we could modify this PR to try to avoid double-creation of the drivers e.g. with a promise-singleton type pattern seen elsewhere in the codebase