Restore ability to load plugins from relative URL #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Codecov Report
@@ Coverage Diff @@
## main #2563 +/- ##
==========================================
- Coverage 60.86% 60.86% -0.01%
==========================================
Files 547 547
Lines 25727 25734 +7
Branches 6078 6076 -2
==========================================
+ Hits 15659 15663 +4
- Misses 9743 9746 +3
Partials 325 325
Continue to review full report at Codecov.
|
garrettjstevens
added
bug
cmdcolin
reviewed
Dec 8, 2021
packages/core/PluginLoader.ts
Outdated
| ) | ||
| } catch (error) { | ||
| console.error(`Error parsing URL: ${pluginDefinition.cjsUrl}`) | ||
| throw error |
There was a problem hiding this comment.
maybe
throw new Error(`Error parsing URL: ${pluginDefinition.cjsUrl}`)
?
There was a problem hiding this comment.
I thought about that, but wanted to keep the original error in case it had any relevant information. I guess that's not likely, though, so maybe I can log the original error and then throw the custom error since that's what users will see in the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2562
This passes the window location as a second argument to the URL constructor. If a plugin definition has a full URL, the second argument gets ignored, but if a plugin definition has a relative URL it is resolved relative to the window location. Examples of how the resolution works are here.
It also logs an error message with the name of the failed URL since that's not included in the native error message.