Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get parent feature in jexl syntax with either parent(feature) or get(feature,'parent') #2629

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jan 10, 2022

This adds two options for inspecting the parent feature in jexl callbacks

  1. parent(feature), using an added jexl function
  2. get(feature,'parent'), using an extra check to the get method in SimpleFeature
    Fixes Unable to access parent feature in config JEXL #2630

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #2629 (2732f6b) into main (4c0e1ba) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2629      +/-   ##
==========================================
- Coverage   60.58%   60.57%   -0.01%     
==========================================
  Files         558      558              
  Lines       25992    25998       +6     
  Branches     6339     6343       +4     
==========================================
+ Hits        15746    15749       +3     
- Misses       9919     9922       +3     
  Partials      327      327              
Impacted Files Coverage Δ
packages/core/util/jexl.ts 67.79% <50.00%> (-0.63%) ⬇️
packages/core/util/simpleFeature.ts 84.90% <80.00%> (-0.81%) ⬇️
packages/core/assemblyManager/assemblyManager.ts 67.10% <0.00%> (-1.32%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0e1ba...2732f6b. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 11, 2022
@cmdcolin cmdcolin changed the title Add parent getter for jexl/simplefeature Add ability to get parent feature in jexl syntax with either parent(feature) or get(feature,'parent') Jan 11, 2022
@cmdcolin cmdcolin merged commit 76c79ca into main Jan 12, 2022
@cmdcolin cmdcolin deleted the add_parent_getter branch January 12, 2022 19:16
cmdcolin added a commit that referenced this pull request Jan 14, 2022
cmdcolin added a commit that referenced this pull request Jan 19, 2022
…e URL (#2165)

* Session spec URL

* Add showTrack

* Simple jb1-style url params

* Minor refactoring

* Fix lint

* More tweaks

* Return a callback that is called after pluginManager initialized that performs the final loading of views and locations

* Fix crash on demo

* Re-style no config message

* Updates

* Improve error messages

* Add some test for spec url

* Add test for spec url

* Fix lint

* Update fake mock

* Update stuff

* Use a extension point for view opening

* Remove react-measure in favor of react-sizeme

* Add a sizeme mock

* Add circular view launcher example

* Merge origin/main

* Typescript inference of string

* Catch more errors during load

* Fix logic for launching circular view dynamically

* Update plugins/linear-genome-view/src/index.ts

Co-authored-by: Garrett Stevens <stevens.garrett.j@gmail.com>

* Update plugins/circular-view/src/index.ts

Co-authored-by: Garrett Stevens <stevens.garrett.j@gmail.com>

* Update plugins/linear-genome-view/src/LinearGenomeView/index.tsx

Co-authored-by: Garrett Stevens <stevens.garrett.j@gmail.com>

* Add concept for continuing even if a trackid failed to be found

* Slightly better suspense behavior on help dialog

* Fix broken @jbrowse/core build in v1.5.5 with fixed typescript babel config (#2637)

* Move @babel/preset-typescript last in list (which is actually first to be processed)

* Use monorepo root babel config for core

Co-authored-by: Garrett Stevens <stevens.garrett.j@gmail.com>

* [update docs] Update v1.5.5 blogpost with v1.5.4 contents

* Add ability to get parent feature in jexl syntax with either parent(feature) or get(feature,'parent') (#2629)

* Release draft announcement v1.5.6 (#2639)

* [skip ci] Add release notes for v1.5.6

* Update v1.5.6.md

* Prepare for v1.5.6 release

* [update docs] v1.5.6

* Add vertical resize handle to dotplot view (#2632)

* Add v1.5.7 release announcement

* Prepare for v1.5.7 release

* [update docs] v1.5.7

* Remove unneeded postpublish on core

* Add v1.5.8 release notes

* Prepare for v1.5.8 release

* [update docs] v1.5.8

* [update docs] Update v1.5.8 blogpost and remove v1.5.7 and v1.5.6

* Fix core by not using absolute runtime in babel (#2645)

* Add v1.5.9 release announcement

* No-op change so that lerna changed in scripts/release.sh doesn't error out

* Prepare for v1.5.9 release

* [update docs] v1.5.9

* Bump follow-redirects from 1.14.6 to 1.14.7 (#2643)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.6 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.6...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump follow-redirects from 1.13.0 to 1.14.7 in /website (#2642)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.0 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.13.0...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump deps in website directory

* Avoid console.warns in tests due to writing to MST nodes that are not alive (#2648)

* Alternative method with async extension point

* Change to an async extension point

Co-authored-by: Garrett Stevens <stevens.garrett.j@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to access parent feature in config JEXL
1 participant