Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cypress test of package that uses embedded components #2649

Merged
merged 8 commits into from
Jan 19, 2022
Merged

Conversation

garrettjstevens
Copy link
Collaborator

Fixes #2647

This adds a package in component_test off the monorepo root that uses create-react-app to make an app with an embedded react-linear-genome-view. When the whole repo is built in CI, each package creates a .tgz of itself and copies it to the test package. Then, when all the packages are build, the component_test packages is built and is set to resolve all the @jbrowse packages to their new builds. That way it's using all the most recent versions of the built packages.

Then in CI it runs a Cypress test to make sure the package built correctly.

This PR also fixes several cases where files in @jbrowse/core were using imports like import { ConfigurationSchema } from '@jbrowse/core/configuration' when they should be local imports like import { ConfigurationSchema } from './configuration', since those caused the component_test package to break.

@garrettjstevens garrettjstevens self-assigned this Jan 14, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 14, 2022
@garrettjstevens garrettjstevens changed the title Embedded tests Add Cypress test of package that uses embedded components Jan 14, 2022
@garrettjstevens garrettjstevens added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 14, 2022
@garrettjstevens garrettjstevens added this to In progress in JBrowse team board Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #2649 (c4ba67b) into main (d95dc2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2649   +/-   ##
=======================================
  Coverage   60.57%   60.57%           
=======================================
  Files         557      557           
  Lines       25999    25999           
  Branches     6343     6343           
=======================================
  Hits        15750    15750           
  Misses       9922     9922           
  Partials      327      327           
Impacted Files Coverage Δ
packages/core/CorePlugin.ts 88.88% <ø> (ø)
packages/core/data_adapters/CytobandAdapter.ts 41.66% <ø> (ø)
...uggableElementTypes/models/InternetAccountModel.ts 39.13% <ø> (ø)
packages/core/ui/AssemblySelector.tsx 100.00% <ø> (ø)
packages/core/ui/DrawerWidget.tsx 80.76% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95dc2c...c4ba67b. Read the comment docs.

@cmdcolin
Copy link
Collaborator

nice work on this one :) will definitely help with the relaibility

@rbuels rbuels merged commit e31cb62 into main Jan 19, 2022
JBrowse team board automation moved this from In progress to Done Jan 19, 2022
@rbuels rbuels deleted the embedded_tests branch January 19, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

CI testing of embedded components
3 participants