Add a check for empty content blocks to fix rare empty stats estimation #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
bug
Codecov Report
@@ Coverage Diff @@
## main #2766 +/- ##
=======================================
Coverage 60.21% 60.21%
=======================================
Files 571 571
Lines 26576 26578 +2
Branches 6474 6476 +2
=======================================
+ Hits 16003 16005 +2
Misses 10248 10248
Partials 325 325
Continue to review full report at Codecov.
|
cmdcolin
changed the title
|
reported by @bbimber in chat, previous fix was made for this issue but was missed the autorun case which this PR made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fix that was missed in https://github.com/GMOD/jbrowse-components/pull/2719/files to check for empty regions in the autorun