-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizations for alignments tracks and BAM parsing #2809
Conversation
5190cf5
to
7fbf52a
Compare
Codecov Report
@@ Coverage Diff @@
## main #2809 +/- ##
==========================================
- Coverage 60.00% 59.95% -0.05%
==========================================
Files 584 584
Lines 26620 26505 -115
Branches 6464 6429 -35
==========================================
- Hits 15974 15892 -82
+ Misses 10332 10299 -33
Partials 314 314
Continue to review full report at Codecov.
|
ba6fe67
to
0d73c9b
Compare
ae27471
to
8b342d0
Compare
This reverts commit 55211a3.
c904b7d
to
3de425a
Compare
3de425a
to
9b50144
Compare
this had a tricky error in the full build (can be seen in the many red "X" on the builds before the latest build) that was tricky to debug. I think it gave an error from tsdx's version of typescript which is older. |
fixed now though |
I also removed a microptimization that was in the original PR for parsing cigar strings (avoided regex). it was somewhat faster on chrome but didn't strongly impact any jb2profile results for example. it is also slower on firefox. keeping track of some fun microbenchmarks here https://gist.github.com/cmdcolin/ef57d2783e47b16aa07a03967fd870d8 |
~30% faster than main on 1000x longreads (2kb region viewed) some tests here https://github.com/cmdcolin/jb2profile |
This is a little microoptimization for the BAM/CRAM parsing pipeline