Add --prefixSize flag to @jbrowse/cli text-index #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
from pairing with @teresam856 |
github-actions
bot
added
the
needs label triage
cmdcolin
added
enhancement
cmdcolin
force-pushed
the
customizable_prefix_size
branch
from
960b1bd
to
4a31861
Compare
teresam856
reviewed
Apr 14, 2022
| @@ -471,6 +471,9 @@ OPTIONS | |||
|
|
|||
| --perTrack If set, creates an index per track | |||
|
|
|||
| --prefixSize=prefixSize [default: 6] Specify the prefix size for the ixx index, increase size if many of your | |||
| gene IDs have same prefix e.g. Z000000001, Z000000002 | |||
There was a problem hiding this comment.
@cmdcolin I just noticed this defaults to 6 but ixIxx defaults to 5. We should probably default to the same one.
There was a problem hiding this comment.
that is true. it will not cause any issue the way it is now since ixixx doesn't use it's default value, it gets overridden by 6 here, but I can change ixixx to be 6 by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2862
This allows the user to manually specify the prefixSize for the ixixx index
Auto-calculating a prefix size could be an add-on to this, but by allowing at least a manual override we can help some users out first :)