Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read vs ref dotplot view #3007

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Fix read vs ref dotplot view #3007

merged 2 commits into from
Jun 6, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 6, 2022

The read vs ref dotplot view was broken on main since probably about #2746 which added more ref name renaming to dotplot

This fixes the read vs ref dotplot view by using the waitForAssembly utility function in the ref name renaming instead re-implementing it, and the base utility function does not go into infinite waiting if it doesn't find the assembly in the list as is the case with the assemblies used in the dotplot (they are not part of the assemblymanager)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 6, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 6, 2022
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 6, 2022

adds integration test for this workflow also

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #3007 (5504771) into main (ec78642) will increase coverage by 0.53%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3007      +/-   ##
==========================================
+ Coverage   60.79%   61.33%   +0.53%     
==========================================
  Files         584      584              
  Lines       26584    26584              
  Branches     6437     6437              
==========================================
+ Hits        16163    16305     +142     
+ Misses      10114     9972     -142     
  Partials      307      307              
Impacted Files Coverage Δ
packages/core/assemblyManager/assemblyManager.ts 71.62% <50.00%> (ø)
packages/core/util/when.ts 40.54% <0.00%> (-2.71%) ⬇️
.../linear-genome-view/src/LinearGenomeView/index.tsx 84.93% <0.00%> (-0.35%) ⬇️
plugins/dotplot-view/src/DotplotView/model.ts 58.29% <0.00%> (+0.85%) ⬆️
plugins/dotplot-view/src/index.ts 100.00% <0.00%> (+3.57%) ⬆️
...otplot-view/src/DotplotRenderer/DotplotRenderer.ts 75.59% <0.00%> (+14.17%) ⬆️
...s/dotplot-view/src/DotplotView/components/Axes.tsx 87.69% <0.00%> (+32.30%) ⬆️
plugins/dotplot-view/src/util.ts 61.01% <0.00%> (+59.32%) ⬆️
...ns/dotplot-view/src/DotplotView/components/util.ts 83.33% <0.00%> (+60.60%) ⬆️
plugins/dotplot-view/src/DotplotReadVsRef.ts 71.79% <0.00%> (+71.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec78642...5504771. Read the comment docs.

@cmdcolin cmdcolin merged commit da88af0 into main Jun 6, 2022
@cmdcolin cmdcolin deleted the fix_read_vs_ref_dotplot branch June 6, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant