Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to copy track config in About track dialog #3017

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 8, 2022

Allows you to copy the JSON to clipboard using a button click in the about track dialog

image

May help with e.g. #2889

This type of feature requires otherwise going into the chrome dev console to try to copy it out. This feature can allow a little "lightweight" admin server type functionality since you can copy track configs back into your config.json manually.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3017 (845c11c) into main (c64b555) will decrease coverage by 0.00%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##             main    #3017      +/-   ##
==========================================
- Coverage   61.33%   61.32%   -0.01%     
==========================================
  Files         584      584              
  Lines       26589    26596       +7     
  Branches     6439     6442       +3     
==========================================
+ Hits        16309    16311       +2     
- Misses       9973     9978       +5     
  Partials      307      307              
Impacted Files Coverage Δ
packages/core/ui/AboutDialog.tsx 66.00% <18.18%> (-6.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64b555...845c11c. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 8, 2022
@rbuels
Copy link
Contributor

rbuels commented Jun 8, 2022

I like this. Can be useful in a wide variety of scenarios that the admin server doesn't cover

@cmdcolin cmdcolin merged commit 9dd6408 into main Jun 8, 2022
@cmdcolin cmdcolin deleted the copy_config branch June 8, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants