Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choosing trackId when using text-index with --file with --fileId #3020

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 8, 2022

Fixes #2959

Let's you run a command like

jbrowse text-index --file t1.vcf.gz --fileId t1

By default, without --fileId, then the output assumes the trackId will be t1.vcf.gz (equal to the filename) but is overridden by --fileId

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3020 (f023e3a) into main (ba0975e) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3020      +/-   ##
==========================================
- Coverage   61.20%   61.20%   -0.01%     
==========================================
  Files         586      586              
  Lines       26663    26666       +3     
  Branches     6466     6467       +1     
==========================================
+ Hits        16319    16320       +1     
- Misses      10037    10038       +1     
- Partials      307      308       +1     
Impacted Files Coverage Δ
products/jbrowse-cli/src/commands/text-index.ts 69.23% <50.00%> (-0.77%) ⬇️
...quenceRenderer/components/DivSequenceRendering.tsx 92.55% <0.00%> (-2.13%) ⬇️
.../linear-genome-view/src/LinearGenomeView/index.tsx 85.23% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0975e...f023e3a. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 8, 2022
@cmdcolin cmdcolin requested a review from teresam856 June 9, 2022 19:10
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 9, 2022

@bbimber do you think this would cover your use case for text indexing?

@bbimber
Copy link
Contributor

bbimber commented Jun 9, 2022

@cmdcolin Yes, at least based off the code alone, I think this would.

Copy link
Contributor

@teresam856 teresam856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this override the entire track configuration with the new track id?

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 9, 2022

The --file argument does not have any configuration file, so it just generates some trix (ix,ixx,meta.json) outputs. The --fileId argument would only rename the trackId that is used in those output files

@teresam856
Copy link
Contributor

Gotcha. It would only be utilized to override the track id that is inferred from the file name that is being indexed.

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 9, 2022

yep!

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 9, 2022

maybe can merge for now:)

@cmdcolin cmdcolin merged commit 2480a68 into main Jun 9, 2022
@cmdcolin cmdcolin deleted the override_trackid_perfile branch June 9, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disconnect between trackId of trix index and trackId of session
3 participants