-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow choosing trackId when using text-index with --file with --fileId #3020
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
- Coverage 61.20% 61.20% -0.01%
==========================================
Files 586 586
Lines 26663 26666 +3
Branches 6466 6467 +1
==========================================
+ Hits 16319 16320 +1
- Misses 10037 10038 +1
- Partials 307 308 +1
Continue to review full report at Codecov.
|
@bbimber do you think this would cover your use case for text indexing? |
@cmdcolin Yes, at least based off the code alone, I think this would. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this override the entire track configuration with the new track id?
The --file argument does not have any configuration file, so it just generates some trix (ix,ixx,meta.json) outputs. The --fileId argument would only rename the trackId that is used in those output files |
Gotcha. It would only be utilized to override the track id that is inferred from the file name that is being indexed. |
yep! |
maybe can merge for now:) |
Fixes #2959
Let's you run a command like
By default, without
--fileId
, then the output assumes the trackId will be t1.vcf.gz (equal to the filename) but is overridden by--fileId