-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating alternative "add track workflows" from within the "Add track" widget #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Jul 21, 2022
cmdcolin
added
enhancement
New feature or request
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Jul 21, 2022
cmdcolin
force-pushed
the
custom_add_track
branch
from
July 21, 2022 23:38
285d003
to
e031cac
Compare
Codecov Report
@@ Coverage Diff @@
## main #3102 +/- ##
==========================================
- Coverage 58.91% 58.85% -0.06%
==========================================
Files 640 644 +4
Lines 28843 28897 +54
Branches 6999 7017 +18
==========================================
+ Hits 16992 17008 +16
- Misses 11469 11511 +42
+ Partials 382 378 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. |
cmdcolin
force-pushed
the
custom_add_track
branch
2 times, most recently
from
July 22, 2022 16:25
c2f2e52
to
5720a9b
Compare
New pluggable element type for addTrackWidget Pluggable add track form Add multiple tracks Typescripting Rename add track widget->add track workflow
cmdcolin
force-pushed
the
custom_add_track
branch
2 times, most recently
from
July 22, 2022 22:38
f78aea4
to
6aa9317
Compare
cmdcolin
force-pushed
the
custom_add_track
branch
from
July 22, 2022 23:12
6aa9317
to
55261ba
Compare
might go ahead with merge, can revert if the idea is too weird :) |
cmdcolin
force-pushed
the
custom_add_track
branch
from
July 22, 2022 23:37
55261ba
to
6651842
Compare
cmdcolin
force-pushed
the
custom_add_track
branch
from
July 22, 2022 23:43
6651842
to
a84557e
Compare
cmdcolin
force-pushed
the
custom_add_track
branch
from
July 25, 2022 18:45
a5d341f
to
8c7d532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a concept of having different workflows inside the Add track widget.
This is helpful for adding track types that are sufficiently different from the normal add track workflow we have, such as creating a multibigwig by pasting a list of files
Example screenshot
fig 1. the multi-wiggle add track widget
fig 2. the select box showing the different add track widget options
I propose this as a new pluggable element type called "add track workflow" that consists basically of a ReactComponent. This component is displayed fully separately from the stepper in the normal workflow (does not tie into the stepper workflow)