Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating alternative "add track workflows" from within the "Add track" widget #3102

Merged
merged 15 commits into from
Jul 25, 2022

Conversation

cmdcolin
Copy link
Collaborator

This creates a concept of having different workflows inside the Add track widget.

This is helpful for adding track types that are sufficiently different from the normal add track workflow we have, such as creating a multibigwig by pasting a list of files

Example screenshot

Screenshot from 2022-07-21 13-41-01
fig 1. the multi-wiggle add track widget

Screenshot from 2022-07-21 13-41-22
fig 2. the select box showing the different add track widget options

I propose this as a new pluggable element type called "add track workflow" that consists basically of a ReactComponent. This component is displayed fully separately from the stepper in the normal workflow (does not tie into the stepper workflow)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 21, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 21, 2022
@cmdcolin cmdcolin changed the base branch from main to multiwiggle2 July 21, 2022 20:28
Base automatically changed from multiwiggle2 to main July 21, 2022 22:38
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #3102 (98d484e) into main (18290ec) will decrease coverage by 0.05%.
The diff coverage is 52.78%.

@@            Coverage Diff             @@
##             main    #3102      +/-   ##
==========================================
- Coverage   58.91%   58.85%   -0.06%     
==========================================
  Files         640      644       +4     
  Lines       28843    28897      +54     
  Branches     6999     7017      +18     
==========================================
+ Hits        16992    17008      +16     
- Misses      11469    11511      +42     
+ Partials      382      378       -4     
Impacted Files Coverage Δ
...kages/core/BaseFeatureWidget/BaseFeatureDetail.tsx 73.14% <0.00%> (-0.43%) ⬇️
packages/core/util/index.ts 85.57% <0.00%> (-1.93%) ⬇️
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 73.38% <ø> (ø)
plugins/bed/src/BedAdapter/BedAdapter.ts 85.71% <ø> (ø)
plugins/bed/src/BedTabixAdapter/BedTabixAdapter.ts 90.24% <ø> (ø)
plugins/bed/src/util.ts 88.31% <ø> (ø)
plugins/data-management/src/index.ts 90.00% <ø> (ø)
plugins/menus/src/AboutWidget/index.ts 100.00% <ø> (ø)
plugins/menus/src/HelpWidget/index.ts 100.00% <ø> (ø)
...rtSessionWidget/components/ImportSessionWidget.tsx 0.00% <0.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@cmdcolin cmdcolin force-pushed the custom_add_track branch 2 times, most recently from c2f2e52 to 5720a9b Compare July 22, 2022 16:25
@cmdcolin cmdcolin force-pushed the custom_add_track branch 2 times, most recently from f78aea4 to 6aa9317 Compare July 22, 2022 22:38
@cmdcolin
Copy link
Collaborator Author

might go ahead with merge, can revert if the idea is too weird :)

@cmdcolin cmdcolin merged commit ce86b94 into main Jul 25, 2022
@cmdcolin cmdcolin deleted the custom_add_track branch July 25, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant