Make ideogram menu item similar to others #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3137 +/- ##
=======================================
Coverage 58.81% 58.82%
=======================================
Files 648 648
Lines 29042 29041 -1
Branches 7067 7066 -1
=======================================
Hits 17082 17082
+ Misses 11581 11580 -1
Partials 379 379
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
looks good to me. making all the menu items behave more similarly increases overall ease of use! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This standardizes the ideogram LGV menu item so that it is more like the others.
Before:
After:
It also changes "Show gridlines" to "Show guidelines". Since there are no horizontal lines, only vertical ones, that are hidden/shown, it isn't a grid, so I think "guidelines" is more clear. It could also be "Show vertical guidelines" to be more explicit, or something else entirely if anyone has suggestions.