Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more defaults in rollup plugins #3165

Merged
merged 1 commit into from Sep 1, 2022

Conversation

garrettjstevens
Copy link
Collaborator

This removes some customization from the rollup plugins in the plugin-development-tools package. The customizations were originally brought in from the TSDX template we used to create the rolllup config. In my testing in Apollo, the defaults actually end up having more consistent and reliable behavior than these customizations.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #3165 (6009969) into main (4b422e7) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3165      +/-   ##
==========================================
- Coverage   59.48%   59.46%   -0.03%     
==========================================
  Files         667      667              
  Lines       28606    28606              
  Branches     6923     6923              
==========================================
- Hits        17017    17010       -7     
- Misses      11268    11275       +7     
  Partials      321      321              
Impacted Files Coverage Δ
...svg/src/SvgFeatureRenderer/components/Segments.tsx 85.71% <0.00%> (-7.15%) ⬇️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 80.55% <0.00%> (-5.56%) ⬇️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 91.83% <0.00%> (-4.09%) ⬇️
...FeatureRenderer/components/ProcessedTranscript.tsx 87.32% <0.00%> (-1.41%) ⬇️
packages/core/util/layouts/GranularRectLayout.ts 86.86% <0.00%> (-0.43%) ⬇️
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator

sounds good to me!

@garrettjstevens garrettjstevens merged commit 09cf4aa into main Sep 1, 2022
@garrettjstevens garrettjstevens deleted the rollup_plugin_more_defaults branch September 1, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants