Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TypeScript for queueDialog #3228

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Improve TypeScript for queueDialog #3228

merged 1 commit into from
Sep 29, 2022

Conversation

garrettjstevens
Copy link
Collaborator

This makes it so the queueDialog method type on the AbstractSessionModel checks that the props passed to it match the component passed to it, instead of being any. The other changes in this PR fix the type errors revealed by this change.

@garrettjstevens garrettjstevens self-assigned this Sep 29, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #3228 (e3517c3) into main (214b57c) will decrease coverage by 0.00%.
The diff coverage is 56.25%.

❗ Current head e3517c3 differs from pull request most recent head c60651c. Consider uploading reports for the commit c60651c to get more accurate results

@@            Coverage Diff             @@
##             main    #3228      +/-   ##
==========================================
- Coverage   59.42%   59.42%   -0.01%     
==========================================
  Files         672      672              
  Lines       28782    28753      -29     
  Branches     6998     6988      -10     
==========================================
- Hits        17105    17086      -19     
+ Misses      11397    11386      -11     
- Partials      280      281       +1     
Impacted Files Coverage Δ
packages/core/util/types/index.ts 67.07% <ø> (-0.40%) ⬇️
...inearPileupDisplay/components/SetFeatureHeight.tsx 0.00% <ø> (ø)
...rc/LinearGenomeView/components/ExportSvgDialog.tsx 3.22% <ø> (ø)
...nearGenomeView/components/SequenceSearchDialog.tsx 0.00% <ø> (ø)
...ins/wiggle/src/CreateMultiWiggleExtension/index.ts 18.18% <0.00%> (-7.75%) ⬇️
...ns/wiggle/src/LinearWiggleDisplay/models/model.tsx 70.72% <0.00%> (ø)
...iLinearWiggleDisplay/components/SetColorDialog.tsx 0.00% <0.00%> (ø)
.../linear-genome-view/src/LinearGenomeView/index.tsx 83.30% <100.00%> (+0.12%) ⬆️
...w/src/LinearGenomeView/components/MiniControls.tsx 50.00% <0.00%> (-6.25%) ⬇️
... and 27 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator

excellent typescripting :) TIL React.ComponentProps

@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 29, 2022
@cmdcolin cmdcolin merged commit b7ea9d9 into main Sep 29, 2022
@cmdcolin cmdcolin deleted the typescript_queueDialog branch September 29, 2022 17:20
cmdcolin pushed a commit that referenced this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants