Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme coloring for components that use overrides e.g. accordion summary #3231

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

garrettjstevens
Copy link
Collaborator

This PR:

  • updates theme.ts to get rid of an any and a @ts-ignore
  • passes the provided theme to the overrides in createJBrowseTheme so that things that are styled by the overrides (e.g. the accordion summary) get the correct theme color

Accordion not being the right color noted by @scottcain here: https://gitter.im/GMOD/jbrowse2?at=6335cacc3a42316d331451a9

@garrettjstevens garrettjstevens added the bug Something isn't working label Sep 29, 2022
@garrettjstevens garrettjstevens self-assigned this Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #3231 (7eba34b) into main (6ceeac5) will increase coverage by 0.00%.
The diff coverage is 77.77%.

@@           Coverage Diff           @@
##             main    #3231   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         672      672           
  Lines       28773    28775    +2     
  Branches     7001     7001           
=======================================
+ Hits        17093    17095    +2     
  Misses      11405    11405           
  Partials      275      275           
Impacted Files Coverage Δ
packages/core/ui/theme.ts 84.61% <77.77%> (+1.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin merged commit 5ef8f93 into main Sep 29, 2022
@cmdcolin cmdcolin deleted the theme_ts_and_fixes branch September 29, 2022 19:15
@cmdcolin cmdcolin changed the title Use provided theme in overrides, update TS types Fix coloring for provided theme in config for components that use overrides, update TS types Oct 3, 2022
@cmdcolin cmdcolin changed the title Fix coloring for provided theme in config for components that use overrides, update TS types Fix theme coloring for components that use overrides e.g. accordion summary, update TS types Oct 3, 2022
@cmdcolin cmdcolin changed the title Fix theme coloring for components that use overrides e.g. accordion summary, update TS types Fix theme coloring for components that use overrides e.g. accordion summary Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants