Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ability to rename session in web/desktop #3269

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

Fixes #3268

Missed wrapping "AppToolbar" component in an observer during refactor in 2.1.5

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #3269 (da5f4b6) into main (4018477) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #3269   +/-   ##
=======================================
  Coverage   59.45%   59.45%           
=======================================
  Files         676      676           
  Lines       28828    28828           
  Branches     7039     7039           
=======================================
  Hits        17139    17139           
  Misses      11415    11415           
  Partials      274      274           
Impacted Files Coverage Δ
packages/core/ui/App.tsx 76.71% <50.00%> (ø)
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 13, 2022
@cmdcolin cmdcolin merged commit 3bbf659 into main Oct 13, 2022
@cmdcolin cmdcolin deleted the fix_rename_session branch October 14, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't change the name of a session
1 participant