Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to open a synteny track directly from the dotplot/linear synteny view import forms #3299

Merged
merged 5 commits into from
Oct 31, 2022

Conversation

cmdcolin
Copy link
Collaborator

Possible fix for #3079

Creates a rudimentary "tracklist" that shows session tracks and config tracks (not connection yet) at the synteny import form, helping users to more easily launch a synteny view

Will look for track types that contain the word 'Synteny' (in case another synteny track type is developed), and check that the track's assemblyNames matches both of the user selected assemblies

Makes it easier for the user to see that "opening their own track" is an optional step too

Screenshot from 2022-10-28 19-05-47

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 29, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 29, 2022
@cmdcolin cmdcolin force-pushed the tracklist_synteny_importform branch 4 times, most recently from f2d30fa to 4f2fb91 Compare October 31, 2022 17:30
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #3299 (e007fa1) into main (b3ae909) will decrease coverage by 0.15%.
The diff coverage is 34.15%.

@@            Coverage Diff             @@
##             main    #3299      +/-   ##
==========================================
- Coverage   59.60%   59.45%   -0.16%     
==========================================
  Files         731      735       +4     
  Lines       28893    28980      +87     
  Branches     6984     7011      +27     
==========================================
+ Hits        17222    17230       +8     
- Misses      11427    11504      +77     
- Partials      244      246       +2     
Impacted Files Coverage Δ
...omparative-view/src/LinearComparativeView/model.ts 38.46% <0.00%> (-0.34%) ⬇️
...LinearSyntenyView/components/ImportCustomTrack.tsx 1.85% <1.85%> (ø)
...plotView/components/ImportSyntenyTrackSelector.tsx 4.16% <4.16%> (ø)
...tenyView/components/ImportSyntenyTrackSelector.tsx 4.16% <4.16%> (ø)
packages/core/ui/App.tsx 76.71% <25.00%> (ø)
...dotplot-view/src/DotplotView/components/Header.tsx 48.71% <33.33%> (+4.96%) ⬆️
...ew/src/LinearSyntenyView/components/ImportForm.tsx 45.09% <44.00%> (+9.20%) ⬆️
...w/src/DotplotView/components/ImportCustomTrack.tsx 59.25% <59.25%> (ø)
...lot-view/src/DotplotView/components/ImportForm.tsx 80.48% <80.76%> (+12.95%) ⬆️
...torWidget/components/HierarchicalTrackSelector.tsx 74.39% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

I think this should be good to go, adding connection tracks could be a component of a future PR

@rbuels
Copy link
Contributor

rbuels commented Oct 31, 2022

When a file is selected in that box, is the track added? That is, if they open another synteny view later, will the file they opened be in the available tracks? If so, maybe change the radio buttons to "None", "Existing track", "New track"

@cmdcolin
Copy link
Collaborator Author

That is, if they open another synteny view later, will the file they opened be in the available tracks?

yes, it will become a "session track" after they open it. that lingo sounds good too also, updated

@cmdcolin cmdcolin merged commit d4116c8 into main Oct 31, 2022
@cmdcolin cmdcolin deleted the tracklist_synteny_importform branch October 31, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants