Improve rubberband zooming across elided regions #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
bug
cmdcolin
force-pushed
the
improve_rubberband_ellided
branch
from
d94002e
to
95a95c1
Compare
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rubberbanding selection+zoom in across ellided regions results in a inaccurate zoom
The reason comes down to assuming every region has an interRegionPaddingBlock but ellided regions do not
Can test on these links: rubberband zoom across the many ellided regions
main branch
https://jbrowse.org/code/jb2/main/?session=share-9S4NOE2u-q&password=Y1Uhn
this branch
https://jbrowse.org/code/jb2/improve_rubberband_ellided/?session=share-9S4NOE2u-q&password=Y1Uhn
Even this branch is not perfect, it seems to underestimate slightly, while main branch does overestimation