Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix force flag for drawing large regions and node-fetch polyfill for node 18 fix in @jbrowse/img #3339

Merged
merged 12 commits into from
Nov 17, 2022

Conversation

cmdcolin
Copy link
Collaborator

Adds typescripting to @jbrowse/img

Also fixes a couple issues brought up in #3331 specifically the use of the force:true flag

Fixes #3338

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 17, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #3339 (d59b2af) into main (b903476) will increase coverage by 0.00%.
The diff coverage is 2.33%.

@@           Coverage Diff           @@
##             main    #3339   +/-   ##
=======================================
  Coverage   59.19%   59.19%           
=======================================
  Files         749      749           
  Lines       29240    29236    -4     
  Branches     7083     7079    -4     
=======================================
- Hits        17308    17307    -1     
- Misses      11683    11735   +52     
+ Partials      249      194   -55     
Impacted Files Coverage Δ
...AlignmentsDisplay/components/AlignmentsDisplay.tsx 56.25% <ø> (ø)
...nce/src/IndexedFastaAdapter/IndexedFastaAdapter.ts 84.09% <ø> (-0.70%) ⬇️
products/jbrowse-img/src/index.testmod.js 0.00% <0.00%> (ø)
products/jbrowse-img/src/index.ts 0.00% <0.00%> (ø)
products/jbrowse-img/src/parseArgv.testmod.js 0.00% <0.00%> (ø)
products/jbrowse-img/src/parseArgv.ts 0.00% <0.00%> (ø)
products/jbrowse-img/src/renderRegion.tsx 0.00% <0.00%> (ø)
products/jbrowse-img/src/util.ts 0.00% <0.00%> (ø)
...ments/src/LinearAlignmentsDisplay/models/model.tsx 66.29% <40.00%> (ø)
packages/core/util/io/index.ts 52.72% <50.00%> (+0.94%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

this now also is using the srcMain/distMain on the @jbrowse/react-linear-genome-view. this avoids having to use "pretest-jbimg" that builds the @jbrowse/react-linear-genome-view

@cmdcolin cmdcolin changed the title Fix force flag on alignments track with @jbrowse/img Fix force flag on alignments track and force node-fetch polyfill on @jbrowse/img Nov 17, 2022
@cmdcolin cmdcolin changed the title Fix force flag on alignments track and force node-fetch polyfill on @jbrowse/img Fix force flag on alignments track and force node-fetch polyfill for node 18 fix on @jbrowse/img Nov 17, 2022
@cmdcolin cmdcolin changed the title Fix force flag on alignments track and force node-fetch polyfill for node 18 fix on @jbrowse/img Fix force flag and node-fetch polyfill for node 18 fix in @jbrowse/img Nov 17, 2022
@cmdcolin cmdcolin changed the title Fix force flag and node-fetch polyfill for node 18 fix in @jbrowse/img Fix force flag for drawing large regions and node-fetch polyfill for node 18 fix in @jbrowse/img Nov 17, 2022
@cmdcolin cmdcolin force-pushed the typescriptify_jbrowse_img branch 2 times, most recently from c69a15f to 5ab1a82 Compare November 17, 2022 22:03
@cmdcolin cmdcolin merged commit dcf13ab into main Nov 17, 2022
@cmdcolin cmdcolin deleted the typescriptify_jbrowse_img branch November 17, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of force:true on @jbrowse/img
1 participant