-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix force flag for drawing large regions and node-fetch polyfill for node 18 fix in @jbrowse/img #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Nov 17, 2022
cmdcolin
force-pushed
the
typescriptify_jbrowse_img
branch
from
November 17, 2022 20:51
01112d0
to
9cbbd1e
Compare
cmdcolin
added
bug
Something isn't working
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Nov 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #3339 +/- ##
=======================================
Coverage 59.19% 59.19%
=======================================
Files 749 749
Lines 29240 29236 -4
Branches 7083 7079 -4
=======================================
- Hits 17308 17307 -1
- Misses 11683 11735 +52
+ Partials 249 194 -55
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
… easier @jbrowse/img testing
cmdcolin
force-pushed
the
typescriptify_jbrowse_img
branch
from
November 17, 2022 21:18
9cbbd1e
to
1701e41
Compare
this now also is using the srcMain/distMain on the @jbrowse/react-linear-genome-view. this avoids having to use "pretest-jbimg" that builds the @jbrowse/react-linear-genome-view |
cmdcolin
changed the title
Fix force flag on alignments track with @jbrowse/img
Fix force flag on alignments track and force node-fetch polyfill on @jbrowse/img
Nov 17, 2022
cmdcolin
changed the title
Fix force flag on alignments track and force node-fetch polyfill on @jbrowse/img
Fix force flag on alignments track and force node-fetch polyfill for node 18 fix on @jbrowse/img
Nov 17, 2022
cmdcolin
changed the title
Fix force flag on alignments track and force node-fetch polyfill for node 18 fix on @jbrowse/img
Fix force flag and node-fetch polyfill for node 18 fix in @jbrowse/img
Nov 17, 2022
cmdcolin
changed the title
Fix force flag and node-fetch polyfill for node 18 fix in @jbrowse/img
Fix force flag for drawing large regions and node-fetch polyfill for node 18 fix in @jbrowse/img
Nov 17, 2022
cmdcolin
force-pushed
the
typescriptify_jbrowse_img
branch
2 times, most recently
from
November 17, 2022 22:03
c69a15f
to
5ab1a82
Compare
cmdcolin
force-pushed
the
typescriptify_jbrowse_img
branch
from
November 17, 2022 22:22
5ab1a82
to
d59b2af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds typescripting to @jbrowse/img
Also fixes a couple issues brought up in #3331 specifically the use of the force:true flag
Fixes #3338