Retain feature labels in compact display mode for SVG features, and allow turning off keeping feature description without feature label #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
enhancement
cmdcolin
force-pushed
the
svg_features
branch
from
1ea597e
to
cab7c3b
Compare
Codecov Report
@@ Coverage Diff @@
## main #3350 +/- ##
==========================================
- Coverage 59.01% 59.00% -0.01%
==========================================
Files 773 773
Lines 29439 29438 -1
Branches 7116 7115 -1
==========================================
- Hits 17372 17370 -2
- Misses 11873 11874 +1
Partials 194 194
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
might go ahead with this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example, with our "Gencode" gene track:
by default the gene "label" is it's ENCODE ID, and the description is it's "gene symbol". if I was an end user and it was configured this way, it would be difficult on current main to make it so that it just displays the gene symbol. Also, displaying in a compact mode, with the gene labels still displayed, I think is useful. This PR accomplishes both changes
Example screenshot, which is fairly easy to setup after this change