Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ability to use LGV synteny track on inverted alignments #3366

Merged
merged 5 commits into from
Dec 1, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 1, 2022

The "Open in synteny view" feature of "LGV synteny displays" introduced in v2.2.1 did not properly navigate to inverted segments

It will also now horizontally flip the view automatically when you use the "Open in synteny view" feature on a inverted segment

A volvox example (volvox-del-rev, which is a volvox.fa with a large deletion + reverse complement of the entire thing) are added to help demonstrate

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 1, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #3366 (bc0414e) into main (192f2c4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
- Coverage   59.67%   59.66%   -0.01%     
==========================================
  Files         775      775              
  Lines       29531    29535       +4     
  Branches     7160     7157       -3     
==========================================
  Hits        17623    17623              
- Misses      11712    11716       +4     
  Partials      196      196              
Impacted Files Coverage Δ
...ve-view/src/LGVSyntenyDisplay/stateModelFactory.ts 4.16% <0.00%> (-0.25%) ⬇️
...rative-view/src/ServerSideRenderedBlockContent.tsx 62.50% <0.00%> (-4.17%) ⬇️
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)
products/jbrowse-cli/src/commands/text-index.ts 71.32% <0.00%> (+0.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 8435cbc into main Dec 1, 2022
@cmdcolin cmdcolin deleted the rev_alignment_synteny_lgv branch December 1, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant