Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jbrowse upgrade CLI command overwriting config.json with --branch or --nightly options #3375

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 2, 2022

Fixes #3374

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 2, 2022
@cmdcolin cmdcolin changed the title Adjust order of operations in github action Fix jbrowse upgrade potentially overwriting a config.json with --branch or --nightly options Dec 2, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 2, 2022
@cmdcolin cmdcolin changed the title Fix jbrowse upgrade potentially overwriting a config.json with --branch or --nightly options Fix jbrowse upgrade CLI command overwriting config.json with --branch or --nightly options Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #3375 (cf6a10a) into main (cef4792) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3375   +/-   ##
=======================================
  Coverage   59.72%   59.72%           
=======================================
  Files         776      776           
  Lines       29520    29520           
  Branches     7157     7157           
=======================================
  Hits        17631    17631           
  Misses      11693    11693           
  Partials      196      196           
Impacted Files Coverage Δ
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 7f60eb6 into main Dec 2, 2022
@cmdcolin cmdcolin deleted the zip_upgrade_fix branch December 2, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jbrowse upgrade --nightly overwrites existing config.json
1 participant