Simplify RPC watchWorker #3394
Merged
Simplify RPC watchWorker #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
internal
and removed
needs label triage
|
ideally, we don't want to really ever see rpc timeouts. should only come under extreme load that indicates that it is going to crash or something...in any other case, we want to let it try to chug thru the data |
Codecov Report
@@ Coverage Diff @@
## main #3394 +/- ##
==========================================
- Coverage 60.48% 60.48% -0.01%
==========================================
Files 823 823
Lines 29812 29807 -5
Branches 7176 7176
==========================================
- Hits 18033 18028 -5
Misses 11591 11591
Partials 188 188
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible code simplification for the watchWorker RPC
Currently if this fails, it can produce a large stack trace due to the recursion. It's not very obscured by doing so, but seemed sort of awkward so I changed it into a while loop and the code seemed simpler anyways