Variant sample grid auto-size columns and resizer #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
enhancement
|
example screenshot
|
cmdcolin
force-pushed
the
variant_sample_grid
branch
2 times, most recently
from
c3f0fad
to
a38ea76
Compare
cmdcolin
force-pushed
the
variant_sample_grid
branch
from
a38ea76
to
1747689
Compare
Codecov Report
@@ Coverage Diff @@
## main #3470 +/- ##
==========================================
+ Coverage 61.40% 61.43% +0.03%
==========================================
Files 819 820 +1
Lines 29459 29477 +18
Branches 7047 7053 +6
==========================================
+ Hits 18088 18108 +20
+ Misses 11210 11208 -2
Partials 161 161
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the resizer concept from the the faceted PR and also now auto-sizes the columns using the measureGridWidth method that is used in several other data-grid usages in the codebase