Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring default display height #3510

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Feb 7, 2023

Fixes #3030

Makes "height" into a getter on track displays, and uses a preProcessSnapshot to put any existing snapshots e.g. from session shares, into a state model attribute called heightPreConfig

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 7, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #3510 (71cf35c) into main (580f0e3) will increase coverage by 0.02%.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
+ Coverage   61.11%   61.14%   +0.02%     
==========================================
  Files         833      833              
  Lines       29702    29716      +14     
  Branches     7091     7095       +4     
==========================================
+ Hits        18153    18169      +16     
+ Misses      11387    11385       -2     
  Partials      162      162              
Impacted Files Coverage Δ
...src/LinearAlignmentsDisplay/models/configSchema.ts 100.00% <ø> (ø)
...-view/src/BaseLinearDisplay/models/configSchema.ts 50.00% <ø> (ø)
...ments/src/LinearAlignmentsDisplay/models/model.tsx 80.17% <70.00%> (+0.54%) ⬆️
...aseLinearDisplay/models/BaseLinearDisplayModel.tsx 86.98% <88.88%> (+0.27%) ⬆️
packages/core/ui/ResizeBar.tsx 77.41% <0.00%> (+9.67%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Feb 7, 2023

seems pretty straightforward, probably can merge

@cmdcolin cmdcolin merged commit 2eb2a02 into main Feb 8, 2023
@cmdcolin cmdcolin deleted the config_display_height branch February 8, 2023 22:28
@cmdcolin cmdcolin changed the title Config display height Allow configuring default display height Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to configure the default height of a track display
1 participant