Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing grid ticks in dotplot #3525

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Fix missing grid ticks in dotplot #3525

merged 2 commits into from
Feb 17, 2023

Conversation

cmdcolin
Copy link
Collaborator

Also adds a overflow:hidden to the LGV overview scale bar header, currently the text can go outside the box which is visually a bit glitchy

Before
Screenshot from 2023-02-17 10-25-31

After
Screenshot from 2023-02-17 10-25-40

Dotplot

Before
Screenshot from 2023-02-17 10-27-53

After
Screenshot from 2023-02-17 10-28-02

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 17, 2023
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 17, 2023
@cmdcolin cmdcolin force-pushed the grid_pitch branch 2 times, most recently from 2a34f97 to 93255d2 Compare February 17, 2023 20:42
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #3525 (08f3737) into main (b645ef1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3525   +/-   ##
=======================================
  Coverage   62.57%   62.58%           
=======================================
  Files         862      862           
  Lines       30164    30164           
  Branches     7234     7234           
=======================================
+ Hits        18875    18877    +2     
+ Misses      11101    11099    -2     
  Partials      188      188           
Impacted Files Coverage Δ
...c/LinearGenomeView/components/OverviewScalebar.tsx 88.04% <ø> (ø)
...ns/dotplot-view/src/DotplotView/components/util.ts 86.36% <100.00%> (ø)
...ns/linear-genome-view/src/LinearGenomeView/util.ts 95.45% <100.00%> (ø)
...s/dotplot-view/src/DotplotView/components/Axes.tsx 96.96% <0.00%> (+3.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 363f1ce into main Feb 17, 2023
@cmdcolin cmdcolin deleted the grid_pitch branch February 17, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant