Use double-click to zoom in on particular offset in LGV, and make ctrl+scroll also zoom in on particular offset #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
force-pushed
the
double_click_zoom
branch
from
7e2049d
to
341a9dc
Compare
cmdcolin
added
enhancement
github-actions
bot
added
the
needs label triage
cmdcolin
removed
the
needs label triage
|
also makes ctrl+scroll zoom in on mouse pointer offset |
cmdcolin
commented
Mar 6, 2023
| @@ -239,7 +239,12 @@ export function useRangeSelect( | |||
|
|
|||
| export function useWheelScroll( | |||
| ref: React.RefObject<HTMLDivElement>, | |||
| model: LGV, | |||
| model: { | |||
There was a problem hiding this comment.
ends up with circular reference so duck typed here now
cmdcolin
force-pushed
the
double_click_zoom
branch
from
341a9dc
to
907f881
Compare
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3544