Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for UCSC assembly hubs and single-file hubs #3627

Closed
wants to merge 18 commits into from

Conversation

rbuels
Copy link
Contributor

@rbuels rbuels commented Apr 5, 2023

will require @gmod/ucsc-hub ^0.2.0, see GMOD/ucsc-hub-js#34

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #3627 (43ab78c) into main (ee8c2bd) will decrease coverage by 0.25%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 43ab78c differs from pull request most recent head 892ec10. Consider uploading reports for the commit 892ec10 to get more accurate results

@@            Coverage Diff             @@
##             main    #3627      +/-   ##
==========================================
- Coverage   63.18%   62.93%   -0.25%     
==========================================
  Files        1044      871     -173     
  Lines       30548    30196     -352     
  Branches     7285     7271      -14     
==========================================
- Hits        19301    19005     -296     
+ Misses      11078    11005      -73     
- Partials      169      186      +17     
Files Coverage Δ
packages/core/configuration/configurationSchema.ts 79.64% <100.00%> (+0.36%) ⬆️
packages/core/configuration/util.ts 88.04% <100.00%> (-2.07%) ⬇️
packages/core/ui/FileSelector/FileSelector.tsx 50.76% <100.00%> (+6.82%) ⬆️
plugins/data-management/src/index.ts 100.00% <100.00%> (ø)
...gins/data-management/src/ucsc-hubs/configSchema.ts 50.00% <ø> (ø)
plugins/data-management/src/ucsc-hubs/index.ts 100.00% <ø> (ø)
plugins/data-management/src/ucsc-hubs/model.ts 76.74% <ø> (ø)
...gins/data-management/src/ucsc-hubs/ucscTrackHub.ts 59.57% <ø> (ø)

... and 728 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@rbuels rbuels added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Apr 20, 2023
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 20, 2023
@cmdcolin
Copy link
Collaborator

i think this PR, as implemented, will probably get closed. we will keep trying to make single file hubs happen though. I have tried to keep pushing it forward, and also had a note in GMOD/ucsc-hub-js#36 on how a potential refactoring could help out

@cmdcolin cmdcolin closed this Nov 20, 2023
@cmdcolin cmdcolin deleted the ucsc-assembly-hubs branch December 1, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support single file UCSC hub files Support UCSC trackhub supertrack/multiwig configurations
2 participants