Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for single file hubs #34

Merged
merged 11 commits into from
Nov 9, 2023
Merged

Add support for single file hubs #34

merged 11 commits into from
Nov 9, 2023

Conversation

rbuels
Copy link
Contributor

@rbuels rbuels commented Apr 3, 2023

No description provided.

@rbuels
Copy link
Contributor Author

rbuels commented Apr 3, 2023 via email

@cmdcolin
Copy link
Contributor

cmdcolin commented Apr 3, 2023

we don't use assert in any of our other libraries currently as far as I know, so it's a little out of place to me, and it seems like it can instead use a jest 'expect' type statement instead? it is also a node built-in, but it is being installed as an npm module https://www.npmjs.com/package/assert

@rbuels
Copy link
Contributor Author

rbuels commented Apr 3, 2023 via email

@cmdcolin
Copy link
Contributor

cmdcolin commented Apr 3, 2023

if you can add a comment saying why it is there (e.g. the typescript thing) it may help future readers, but otherwise it is fine

@rbuels rbuels linked an issue Apr 20, 2023 that may be closed by this pull request
@cmdcolin cmdcolin marked this pull request as ready for review November 9, 2023 18:57
@cmdcolin cmdcolin changed the title support for single file hubs Add support for single file hubs Nov 9, 2023
@cmdcolin
Copy link
Contributor

cmdcolin commented Nov 9, 2023

let's get this one going :)

@cmdcolin cmdcolin merged commit 1bb04e0 into master Nov 9, 2023
1 check passed
@cmdcolin cmdcolin deleted the single-file-hub branch November 9, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single file hub
2 participants