Check session tracks for text search adapters #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shashank Budhanuru Ramaraju <shashank.b.r.gowda45587@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3767 +/- ##
==========================================
- Coverage 64.11% 64.10% -0.02%
==========================================
Files 987 987
Lines 29663 29664 +1
Branches 7094 7094
==========================================
- Hits 19018 19015 -3
- Misses 10481 10485 +4
Partials 164 164
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
good catch indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
trackson the session instead of from the JBrowse config when checking for track-level text search adapters. This way session tracks get checked for text search adapters as well as tracks in the config.Credit to @shashankbrgowda for figuring out that the text search manager was missing the session tracks: GMOD/Apollo3#231 (comment).