Add forwardRef to wrapped re-exported lazy components #3887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed I was getting console errors and strange behavior when using the MUI
Tooltip
on another MUI component. Specifically I was usingTooltip
to wrapIconButton
, but the tooltip wouldn't appear until after the button had been clicked on. Eventually I found this docs page: https://mui.com/material-ui/guides/composition/#caveat-with-refsWhat I eventually figured out is that basically, when we wrap lazy components in
Suspsense
, we have to useReact.forwardRef
to pass any refs on to the wrapped component. This allows things likeTooltip
to work as usual.I also had to add some display names after adding
forwardRef
to satisfy the "react/display-name" lint rule.