Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the config.json missing screen to an "It worked!" message #3907

Merged
merged 2 commits into from Sep 13, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Sep 8, 2023

encountering the root config.json not found error in production

updated:

encountering any other error other than root config.json not found in production

image

encountering the root config.json not found error in development

image

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 8, 2023
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #3907 (004efcf) into main (595acd6) will increase coverage by 0.00%.
The diff coverage is 16.66%.

@@           Coverage Diff           @@
##             main    #3907   +/-   ##
=======================================
  Coverage   64.36%   64.36%           
=======================================
  Files        1004     1004           
  Lines       29856    29854    -2     
  Branches     7155     7153    -2     
=======================================
  Hits        19217    19217           
+ Misses      10476    10473    -3     
- Partials      163      164    +1     
Files Changed Coverage Δ
...cts/jbrowse-web/src/components/NoConfigMessage.tsx 0.00% <0.00%> (-58.34%) ⬇️
...wse-web/src/components/StartScreenErrorMessage.tsx 50.00% <33.33%> (-10.00%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 8, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 8, 2023
@cmdcolin cmdcolin changed the title Update NoConfigMessage screen with a "It worked!" message Update config.json missing screen with "It worked!" message Sep 8, 2023
@cmdcolin cmdcolin force-pushed the it_worked_page branch 2 times, most recently from 4580a19 to 86aa499 Compare September 10, 2023 07:08
@cmdcolin
Copy link
Collaborator Author

possible considerations

  • I removed the "green" from the message, and only show "red" on error. This reduces any cognitive load from having to parse what a color might mean, but also might not properly give someone the "right idea"
  • It is a very stripped down page, less that apache2

my guiding principle with this is to make the page as absolutely minimal as possible, so even if you are skimming the page, you "should" find the info you need

@cmdcolin
Copy link
Collaborator Author

Restored the green color, to help with the "green is good" thing :)

image

@cmdcolin
Copy link
Collaborator Author

add note in error screen that error came from jbrowse 2 code

@cmdcolin cmdcolin merged commit 4fc2e2c into main Sep 13, 2023
11 checks passed
@cmdcolin cmdcolin deleted the it_worked_page branch September 13, 2023 19:50
@cmdcolin cmdcolin changed the title Update config.json missing screen with "It worked!" message Change the config.json missing screen to an "It worked!" message Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant