Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature label offsets in SVG exports with main thread RPC #3910

Merged
merged 2 commits into from Sep 8, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Sep 8, 2023

Commonly embedded configurations use main thread RPC, so this helps SVG exports for many embedded users

Fixes #3909

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 8, 2023
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #3910 (da95e4e) into main (9374e84) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3910   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files        1004     1004           
  Lines       29811    29811           
  Branches     7147     7147           
=======================================
  Hits        19231    19231           
  Misses      10415    10415           
  Partials      165      165           
Files Changed Coverage Δ
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 80.95% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 2d91fa5 into main Sep 8, 2023
11 checks passed
@cmdcolin cmdcolin deleted the feature_label_offset_exportsvg branch September 8, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature labels can be misplaced in SVG export with MainThreadRpc
1 participant