Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feature label offsets in SVG exports with main thread RPC #3910

Merged
merged 2 commits into from Sep 8, 2023
Merged

Fix feature label offsets in SVG exports with main thread RPC #3910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfc52ce
Add gene track to mainthread config
cmdcolin Sep 8, 2023
da95e4e
Fix main thread export SVG feature label offsets
cmdcolin Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/svg/src/SvgFeatureRenderer/components/FeatureLabel.tsx
View file
Open in desktop
Expand Up @@ -52,7 +52,7 @@ export default observer(function ({
const totalWidth = featureWidth + allowedWidthExpansion
const measuredTextWidth = measureText(text, fontHeight)
const params =
isStateTreeNode(displayModel) && isAlive(displayModel)
isStateTreeNode(displayModel) && isAlive(displayModel) && !exportSVG
? getViewParams(displayModel)
: viewParams

Expand Down
24 changes: 24 additions & 0 deletions test_data/volvox/config_main_thread.json
View file
Open in desktop
Expand Up @@ -106,6 +106,30 @@
}
}
}
},
{
"type": "FeatureTrack",
"trackId": "gff3tabix_genes",
"assemblyNames": ["volvox"],
"name": "GFF3Tabix genes",
"formatDetails": {
"feature": "jexl:{name:'<a href=https://google.com/?q='+feature.name+'>'+feature.name+'</a>',extrafield:'Field added with custom callback:' + feature.name,phase:undefined,type:undefined}",
"subfeatures": "jexl:{name:'<a href=https://google.com/?q='+feature.name+'>Subfeature: '+(!feature.name?'No name':feature.name)+'</a>'}"
},
"category": ["Miscellaneous"],
"adapter": {
"type": "Gff3TabixAdapter",
"gffGzLocation": {
"uri": "volvox.sort.gff3.gz",
"locationType": "UriLocation"
},
"index": {
"location": {
"uri": "volvox.sort.gff3.gz.tbi",
"locationType": "UriLocation"
}
}
}
}
]
}