Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev mode error from LGV overview scalebar #3937

Merged
merged 1 commit into from Sep 24, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

error message, observed only in chrome devmode in lgv header

Cannot update a component (Unknown) while rendering a different component (Unknown)

spotted by @garrettjstevens

the fix is to avoid calling actions on the dynamically created MST object during render time

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #3937 (c0655ec) into main (eaa4ffa) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3937      +/-   ##
==========================================
- Coverage   63.90%   63.88%   -0.02%     
==========================================
  Files        1013     1013              
  Lines       30165    30166       +1     
  Branches     7194     7194              
==========================================
- Hits        19276    19271       -5     
- Misses      10726    10734       +8     
+ Partials      163      161       -2     
Files Changed Coverage Δ
...c/LinearGenomeView/components/OverviewScalebar.tsx 86.31% <100.00%> (+0.14%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

note: the unknown unknown thing is probably best fixed by adding names to the anonymous functions passed to observer

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 24, 2023
@cmdcolin cmdcolin merged commit b6a567b into main Sep 24, 2023
11 checks passed
@cmdcolin cmdcolin deleted the overviewscalebar_fix branch September 24, 2023 16:44
@cmdcolin cmdcolin changed the title Fix setState error from one component updating while another is rendering Fix dev mode error from LGV overview scalebar Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant