Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow searching by gene name using linear synteny view #4096

Merged
merged 2 commits into from Nov 29, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 29, 2023

Extends #4068 for searching by gene name for a linear synteny view

Fixes #3149

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 29, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 29, 2023
@cmdcolin cmdcolin force-pushed the synteny_url_gene_name branch 2 times, most recently from 3e5cd80 to e2f2fbd Compare November 29, 2023 16:41
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0b51595) 63.45% compared to head (8d44ad1) 63.42%.
Report is 1 commits behind head on main.

Files Patch % Lines
...iew/src/LinearGenomeView/components/ImportForm.tsx 84.61% 2 Missing ⚠️
...ar-comparative-view/src/LaunchLinearSyntenyView.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4096      +/-   ##
==========================================
- Coverage   63.45%   63.42%   -0.03%     
==========================================
  Files        1047     1048       +1     
  Lines       30674    30663      -11     
  Branches     7327     7320       -7     
==========================================
- Hits        19465    19449      -16     
- Misses      11036    11041       +5     
  Partials      173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin
Copy link
Collaborator Author

adds a linear genome view model action: view.navToSearchString({input:string,assembly:Assembly})

this is a little nicer than re-exporting a weird function for this on the plugins/linear-genome-view package i think

@cmdcolin cmdcolin merged commit 87bbb99 into main Nov 29, 2023
11 checks passed
@cmdcolin cmdcolin deleted the synteny_url_gene_name branch November 29, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL query by gene ID in linear genome and linear synteny view
1 participant