Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch breakpoint split view directly from alignments feature details #4215

Merged
merged 8 commits into from
Feb 19, 2024

Conversation

cmdcolin
Copy link
Collaborator

this way, you don't strictly need a VCF track to do so

Fixes #4214
Fixes #689

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 157 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@cdd6716). Click here to learn what that means.

Files Patch % Lines
...tsFeatureDetail/LaunchBreakpointSplitViewPanel.tsx 6.25% 30 Missing ⚠️
...c/AlignmentsFeatureDetail/BreakendOptionDialog.tsx 0.00% 27 Missing ⚠️
...ments/src/AlignmentsFeatureDetail/getSAFeatures.ts 0.00% 23 Missing ⚠️
...gnmentsFeatureDetail/launchBreakpointSplitView.tsx 0.00% 22 Missing ⚠️
...ariants/src/VariantFeatureWidget/BreakendPanel.tsx 5.26% 18 Missing ⚠️
.../src/VariantFeatureWidget/BreakendOptionDialog.tsx 0.00% 12 Missing ⚠️
...nts/src/AlignmentsFeatureDetail/SuppAlignments.tsx 0.00% 10 Missing ⚠️
...ignments/src/AlignmentsFeatureDetail/Formatter.tsx 66.66% 5 Missing ⚠️
...lignments/src/AlignmentsFeatureDetail/PairLink.tsx 0.00% 5 Missing ⚠️
...ignmentsFeatureDetail/SuppAlignmentsLocStrings.tsx 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4215   +/-   ##
=======================================
  Coverage        ?   62.65%           
=======================================
  Files           ?     1084           
  Lines           ?    31311           
  Branches        ?     7469           
=======================================
  Hits            ?    19617           
  Misses          ?    11523           
  Partials        ?      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit 6883fc4 into main Feb 19, 2024
10 checks passed
@cmdcolin cmdcolin deleted the breakpoint_split_reads branch February 19, 2024 14:05
@cmdcolin cmdcolin added the enhancement New feature or request label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant