-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a comparison table for JBrowse Jupyter features #66
Conversation
teresam856
commented
Oct 19, 2022
- adds a feature table to compare JBrowse Jupyter features with other tools' features
Adding a table like this seems like a very good idea. |
@scottcain Awesome. This is the last addition to the readme before I resubmit. |
I think the table looks good! Just a couple comments:
|
|
any reason to referring to "others" without specific reference? |
@cmdcolin No specific reason, but rather to keep it general. (We can include igv-notebook/igv js ) do we think being more specific can help? |
yea i think it would be good to be specific :) |
might be worth mentioning gos |
|
I don't think there is a paper for gos yet. If this presents an issue, maybe just leave it out for now |
OK, having looked at the table:
-- Supports other views aside from the Linear Genome View - e.g Circular Genome View |
So one of our limitations when it comes to local file support is that we need to pass URLs to the JBrowse embedded components rather than paths to local files just like igv-notebook handles it https://github.com/igvteam/igv-notebook#urls-and-paths . Igv-notebook's architecture allows for users to specify paths to files that exist within their mount system or file tree. On the backend they determine wether igv is running on jupyter or google colab and are able to resolve the paths. We are not able to do that with our current architecture. (correct me if I am wrong about this @garrettjstevens). The confusion was that due to an error message that was being provided by JBrowse jupyter that stated "local files were not supported" when in reality, only paths are not supported. We provide ways in which users can leverage the Jupyter server when running jupyter notebook and jupyter lab to pass the formatted urls to JBrowse. We also developed a CORS enabled and range request enabled http server to make it easier for those users who want to serve their local files but are not utilizing jupyter notebook/jupyter lab. |
Ah. I thought this problem was inherent to Jupyter, and I think the text in the response to reviews currently says that too. We should correct that in the response to reviews. And as for this table, can we find a more informative descriptor than "path support"? e.g. "Paths to local files must be passed as URLs"? |
It looks like JupyterLab and Colab both have a way of getting the kernel to open a file (e.g. |
I talked with @rbuels and we figured out a way we think we could open local files in Jupyter and Colab, based on the way igv-notebook does it. The thing I mentioned above, it turns out, is actually a message channel between the client and the kernel. Jupyter's looks like The way we could connect this to JBrowse is by using internetAccounts. For example, we would create a plugin that provided a I can provide more info in a pairing, etc. if needed. |
@garrettjstevens Yeah, we can schedule something. @ihh |
I do think adding local file support would be good. I'm afraid I misunderstood before that this was a fundamental limitation that could not be overcome. If it can, then we sort of have to do it, I think. Thank you @garrettjstevens @teresam856 @rbuels for your flexibility looking into this. I think it is worth doing. |