Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saving cookies on loading/republishing tracks #1272

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

cmdcolin
Copy link
Contributor

This PR attempts to allow the user to save configuration changes across refreshes by storing configs in localStorage. It hooks into jbrowse at a low level and can save edits made via "Edit config" and when the "track replace" publish event is sent. Not all configuration changes use the publish event system though, for example displayMode. However, that could probably be remedied.

Feel free to provide feedback

@ghost ghost assigned cmdcolin Nov 29, 2018
@ghost ghost added the in progress currently being worked on label Nov 29, 2018
@rbuels
Copy link
Collaborator

rbuels commented Dec 26, 2018

I forget, did we all talk about this? Any downsides to merging it?

@cmdcolin
Copy link
Contributor Author

cmdcolin commented Dec 26, 2018

Basically the discussion was that a user could potentially get confused by their own track customizations and forget what defaults are, or if the server side config changed, the users settings still completely replace it (the settings are not merged), and there was no UI indication that a custom track config was being used or to a button to reset it.

@cmdcolin
Copy link
Contributor Author

This also affects simply navigating to different chromosomes too, track settings are refreshed after navigating to different chromosomes without storing settings in localStorage

@bejo-dionnez
Copy link

I agree that users potentially will get confused when track customizations will persist even after refresh. I agree that this could be solved by a UI indication asking if the user wants to load their track costomizations. Or for example the ability to download your customizations to a file and load them when you reload your genome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants