-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the threaded telnet server #747
Comments
I agree, would be nice to merge all of that to only use the Asyncio version. Be careful to test it well on Windows because this is usually the most troublesome platform regarding Telnet.
Telnet server for VMware and VirtualBox acutally uses threads only on Windows because Named Pipes cannot be monitored by select() on this platform (default on OSX/Linux)
Some VMware and VirtualBox appliances are non graphic and you must use Telnet.
Could we / do we need to support SSH? |
SSH will problably creat trouble with the need to include paramiko and all the legal stuff related due to crypto export :( |
It's ok for VMware and VirtualBox on Windows and OSX (should be the same for linux) @Raizo62 serial console should work for VirtualBox |
It works :-D Thanks :-D |
Thanks for the feedback |
Now IOU use the same telnet server. The code is much much simple: |
Actually we have:
My proposal is to put some effort in order to use the docker asyncio code in place of multiple telnet server implementation.
The telnet server use for Docker has many advantage:
And the benefits of a single code base:
The long test session for 2.0 could be the good time to clean that.
The text was updated successfully, but these errors were encountered: