-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build issues #507
base: development
Are you sure you want to change the base?
Build issues #507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Still need to clone and try, but why are you removing openMP flags? Is this no longer necessary, or did you move it?
find OpenMP and set it up
find_package(OpenMP)
if (OPENMP_FOUND)
set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}")
set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}")
endif()
Thanks for taking a look. It's still there. I just needed to move it earlier in the CMakeLists.txt file so it was defined before I set the compiler flags. It looks like it was removed, but it's there starting on line 56. I did turn off building with OpenMP if Address Sanitizer is being used, because they aren't compatible, but no one should be building with address sanitizer except to debug code or out of curiosity. |
I've completed the patch, so it's ready for testing. I don't have access to a newer Intel compiler, so would like to know what happens when building the GPU code with the new ipcx compiler. |
I removed the use of the new Intel LLVM compiler until CUDA supports it. This patch should be ready for testing and merging. Most of the changes are cosmetic -- general code cleanup. For example, I updated the README file, added missing copyright notices to 3rd party software that we are using, standardized the #define for including header files, including fixing some that didn't match the filename, improve the build process, especially for the code, and removed unused files. Once this is approved, we can proceed with the next GOMC release. |
…n parameters so that gcc and intel give consistent results
This is a major reworking of the build process and some related changes to the core non-functional parts of the GOMC repository. The changes include:
This is a necessary step before our next release, so please test the new build process carefully with available compilers.