Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jeeps function pointers, GPS_PPacket const correctness, GPS_Serial_[OSP]Packet -> GPS_Serial_Packet #1215

Merged
merged 8 commits into from
Nov 13, 2023
Merged

jeeps function pointers, GPS_PPacket const correctness, GPS_Serial_[OSP]Packet -> GPS_Serial_Packet #1215

merged 8 commits into from
Nov 13, 2023

Conversation

tsteven4
Copy link
Collaborator

use using for jeeps function pointers.

const correctness for GPS_PPacket use. The important bit here is in gpssend.cc, Build_Serial_Packet used to receive a 1KB packet by copy, now it is by const reference.

original jeeps used GPS_SXXX, GPS_OSXXX, GPS_PXXX for the structure
tag, a typedef of the structure, and a pointer to a typedef of the
structure. In the case of GPS_PPacket this convention was no longer
followed. rename GPS_PPacket -> GPS_Packet.

GPS_Serial_[SOP]Packet -> GPS_Serial_Packet, GPS_Serial_Packet*.

@tsteven4
use using for jeeps function prototypes.
1700c59
@tsteven4
const correctness wrt GPS_PPacket.
c90bb2c 
The important bit here is in gpssend.cc, Build_Serial_Packet used to rececive a 1KB packet by copy, now it is by const reference.
@tsteven4
delete accidentally committed file.
82797a9
@tsteven4
rename GPS_PPacket -> GPS_Packet.
1804cdd 
original jeeps used GPS_SXXX, GPS_OSXXX, GPS_PXXX for the structure
tag, a typedef of the structure, and a pointer to a typedef of the
structure.  In the case of GPS_PPacket this convention was no longer
followed.
@tsteven4
change GPS_Packet back to a structure.
9a5e5b2
@tsteven4
try harder to change GPS_Packet back to a struct.
2bb5543
@tsteven4
clean up GPS_Serial_[SOP]Packet.
c46e66e
@tsteven4
catch some missed renames up.
04e45de 
clion on linux missed some windows only renames.
@robertlipe
Copy link
Collaborator

robertlipe commented Nov 13, 2023 via email

@tsteven4 tsteven4 merged commit f1bcf0d into GPSBabel:master Nov 13, 2023
19 checks passed
@tsteven4 tsteven4 deleted the tidy2 branch November 13, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsteven4 @robertlipe