Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-format descriptor offset relocation changes #594

Closed
wants to merge 1 commit into from
Closed

Re-format descriptor offset relocation changes #594

wants to merge 1 commit into from

Conversation

csyonghe
Copy link

No description provided.

@amdvlk-admin
Copy link
Collaborator

Can one of the admins verify this patch?

@JacobHeAMD
Copy link
Contributor

ok to test

@JacobHeAMD
Copy link
Contributor

test this please

@amdvlk-admin
Copy link
Collaborator

Test summary for commit 0eb9b3a

Driver commits used in build
  • CWPACK: amd-master b601c88aeca7a7b08becb3d32709de383c8ee428
  • METROHASH: amd-master 2b6fee002db6cc92345b02aeee963ebaaf4c0e2f
  • PAL: dev b5e6dde2a0aa5dd2ce6d794e58d89ef715570f2d
  • SPVGEN: dev e843618d71c8263030551e7692b7683f20f627fe
  • XGL: dev 2c44bbc7b58efba12c501f71f5b268f83c1bdad5
  • LLVM-PROJECT: amd-gfx-gpuopen-dev 5ae05ed8bd4f232c8580db96c021cad1e5c300e3
ShaderDB test
  • Passed: 958/958 (100.0%)
  • Failed: 0/958 (0.0%)
CTS tests (built with branch Vulkan-CTS-1.2.0.2-fetch-sources-fix)
    Ubuntu 18.04, Ellesmere
    • Passed: 103142/103142 (100.0%)
    • Failed: 0/103142 (0.0%)
    Ubuntu 18.04, Navi10
    • Passed: 103198/103198 (100.0%)
    • Failed: 0/103198 (0.0%)
    Rhel 7.6, Vega10
    • Passed: 103198/103198 (100.0%)
    • Failed: 0/103198 (0.0%)

@trenouf
Copy link
Member

trenouf commented Apr 21, 2020

Hi @csyonghe. Could you rebase this change please. It looks like there are some formatting errors in the merged #457 that still need fixing.

1 similar comment
@trenouf
Copy link
Member

trenouf commented Apr 21, 2020

Hi @csyonghe. Could you rebase this change please. It looks like there are some formatting errors in the merged #457 that still need fixing.

trenouf added a commit to trenouf/llpc that referenced this pull request Apr 21, 2020
@trenouf
Tidy up descriptor offset relocation changes
84a3d6a 
* Moved emitRelocationConstant from Internal to
BuilderBase::CreateRelocationConstant
* Also subsumed the reformatting of the same change from GPUOpen-Drivers#594.

Change-Id: Ifc3e332af22e0cdac138517cf363622caaca11f3
@trenouf trenouf mentioned this pull request Apr 21, 2020
Merged
trenouf
trenouf requested changes Apr 21, 2020
View reviewed changes
Copy link
Member

@trenouf trenouf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now subsumed by #602. Please abandon this change.

trenouf added a commit to trenouf/llpc that referenced this pull request Apr 21, 2020
@trenouf
Tidy up descriptor offset relocation changes
f8ab725 
* Moved emitRelocationConstant from Internal to
  BuilderBase::CreateRelocationConstant
* Also subsumed the reformatting of the same change from GPUOpen-Drivers#594.
* Also fixed a bug I introduced when rebasing GPUOpen-Drivers#588 "switch
  PatchDescriptorLoad offsets to bytes"

Change-Id: Ifc3e332af22e0cdac138517cf363622caaca11f3
trenouf added a commit that referenced this pull request Apr 22, 2020
@trenouf
Tidy up descriptor offset relocation changes
593e98a 
* Moved emitRelocationConstant from Internal to
  BuilderBase::CreateRelocationConstant
* Also subsumed the reformatting of the same change from #594.
* Also fixed a bug I introduced when rebasing #588 "switch
  PatchDescriptorLoad offsets to bytes"

Change-Id: Ifc3e332af22e0cdac138517cf363622caaca11f3
@csyonghe
Copy link
Author

Some renaming changes in this PR are now included in PR #521

@csyonghe csyonghe closed this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trenouf trenouf trenouf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csyonghe @amdvlk-admin @JacobHeAMD @trenouf