Yiyan add cities #160
Merged
Yiyan add cities #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er map, the point will not move with age changing when changing to timeline-valid raster map. 2. reconstruct presentDayLocations, make sure can be used by different components 3. add cities in vector layer menu, and save data into local storage P.S. cities follow vector layers' rule: it will clean all checked cities when user changes the raster map.
# Conflicts: # src/components/AddLocationWidget.tsx
michaelchin
added a commit
that referenced
this pull request
Oct 2, 2022
Michael Chin: I merged this PR too soon. I just realized that I need more time to merge the changes gradually. Revert the changes for now. I will find time to look into it. This reverts commit b004dd5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P.S. cities follow the vector layers' rule: it will clean all checked cities when the user changes the raster map.