Setup api #206
Merged
Setup api #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebulaval
reviewed
Jul 13, 2023
davebulaval
previously approved these changes
Jul 15, 2023
|
It misses a doc on how to raise the app and use it as an API in the README.md and index.rst. I have placed a placeholder where I see it. It also misses a .env_example to raise the app. Is it possible to add the API doc to the overall documentation? |
|
Added documentation |
davebulaval
previously approved these changes
Jul 17, 2023
|
Is it possible de deactivate sentry in the docker-compose? |
|
Well it is possible to just not use it. Lets say someone set the SENTRY_DSN env variable set to nothing ( |
davebulaval
reviewed
Jul 22, 2023
davebulaval
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup app scripts to allow the use of a REST API to serve AddressParser Models
Docker-compose file added along with app definition