Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Show mentioned SORNs #43

Merged
merged 25 commits into from
Nov 18, 2020
Merged

Show mentioned SORNs #43

merged 25 commits into from
Nov 18, 2020

Conversation

ondrae
Copy link
Contributor

@ondrae ondrae commented Nov 10, 2020 •
edited
Loading

This PR links together all of the SORNs that reference each other by citation number.

Screen Shot 2020-11-10 at 10 41 17 AM

Deploying Instructions

  • Please Squash and Merge this PR after approval, to get rid of the throwaway early code and WIP commits.
  • After deploying run bundle exec rails all_sorns:update_all_mentioned_sorns

Closes #39

@ondrae ondrae changed the title Show referenced SORNs WIP Show referenced SORNs Nov 11, 2020
@ondrae ondrae mentioned this pull request Nov 12, 2020
Closed
@ondrae ondrae changed the title WIP Show referenced SORNs Show mentioned SORNs Nov 12, 2020
@ondrae ondrae changed the title Show mentioned SORNs WIP - Show mentioned SORNs Nov 17, 2020
@ondrae ondrae changed the title WIP - Show mentioned SORNs Show mentioned SORNs Nov 17, 2020
lauraGgit
lauraGgit reviewed Nov 18, 2020
View reviewed changes
Copy link

@lauraGgit lauraGgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing show stopping just a number of comments for consideration before we merge.

app/models/sorn.rb Show resolved Hide resolved
app/views/sorns/search.html.erb Show resolved Hide resolved
spec/models/sorn_spec.rb Show resolved Hide resolved
app/models/sorn.rb Show resolved Hide resolved
@ondrae ondrae merged commit fd2886a into main Nov 18, 2020
@ondrae ondrae deleted the citation-link branch November 18, 2020 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lauraGgit lauraGgit lauraGgit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Next Feature] Linking SORNs via history citations for a-108 SORNs
2 participants
@ondrae @lauraGgit