Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Figure out how to set up automatic testing 😅 #28

Closed
6 tasks
carodew opened this issue Feb 15, 2018 · 6 comments
Closed
6 tasks

Figure out how to set up automatic testing 😅 #28

carodew opened this issue Feb 15, 2018 · 6 comments
Assignees
Labels

Comments

@carodew
Copy link
Contributor

carodew commented Feb 15, 2018

it should include …

  • ping someone in #dev and see if there's someone who can coach us through this
  • figure out what Federalist is testing for already (so we don't duplicate)
  • talking to someone who knows what they're doing (Circle CI, accesslint?)
  • creating clear issues for the work that needs to be done, once we know what that work is

it's done when …

Does not include actually setting up the automatic testing, we'll do that in a separate issue.

outstanding questions

  • how do we even ...
@carodew carodew assigned carodew and unassigned carodew Feb 15, 2018
@carodew carodew added this to the Tech rehearsal milestone Feb 15, 2018
@carodew carodew changed the title Figure out how to set up automatic testing 😅 Figure out how to set up automatic testing 😅 Feb 15, 2018
@carodew carodew removed the blocked label Feb 15, 2018
@carodew carodew self-assigned this Mar 21, 2018
@carodew
Copy link
Contributor Author

carodew commented Mar 23, 2018

what I've learned so far

plainlanguage.gov uses a Circle CI implementation that’s a very basic html check plus a few other things and would probably work fine for us.

This is the html proofer – https://github.com/gjtorikian/html-proofer
and this is plainlanguage.gov's circle ci implementation –https://github.com/GSA/plainlanguage.gov/blob/master/circle.yml

Unless someone else object, I think this is probably our best path forward and is probably good enough – I can dig into how we go about implementing it if I hear no objections. You know what they say, if it's good enough for plainlanguage.gov, it's good enough for me.

@jeremyzilar
Copy link
Contributor

OMG, thank you for digging this up.
Maybe I can ask @hursey013 how he set this up.

@carodew
Copy link
Contributor Author

carodew commented Mar 23, 2018

@jeremyzilar All I did was ask in #dev. :D

and @hursey013 is the person who is giving me tips. :D

He sez – "if you have a config.yml in the root of your project, then you basically just connect your github account with circleci, add the project repo, hit build, and it’ll find the circle.yml"

@carodew
Copy link
Contributor Author

carodew commented Mar 24, 2018

So I've merged the circle.yml file from plainlanguage.gov into demo (probably needs to be merged to prod to but I think whenever the next release is will be fine) and I'm able to run builds in the Circle CI interface.

I do get an error bc htmlproofer is not installed, but it's called in our circle.yml file. I think once someone does that (@thisisdano maybe?) we will be good!

I will update the "install automatic tests" ticket with these details and move the card into Ready.

(I'm only doing this on a Saturday because I realized I left this half done yesterday and figured it'd only take five minutes).

@carodew carodew closed this as completed Mar 24, 2018
@hursey013
Copy link

@carodew you'll want to add htmlproofer to your Gemfile, like so https://github.com/GSA/plainlanguage.gov/blob/master/Gemfile#L6

@thisisdano
Copy link
Contributor

@carodew I added this into the demo branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants