Fix case-sensitivity for automated snyk update script #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Attempt to check if package was previously being specified before automatically adding it because of the scan
Otherwise, the first package will set update for every package
This should help cut down on build+install time with the snyk scan
[Snyk + GH Actions] Update requirements
Jin-Sun-tts
previously approved these changes
Apr 3, 2023
nickumia-reisys
commented
Apr 3, 2023
btylerburton
previously approved these changes
Apr 3, 2023
Jin-Sun-tts
previously approved these changes
Apr 3, 2023
nickumia-reisys
commented
Apr 4, 2023
nickumia-reisys
dismissed stale reviews from Jin-Sun-tts and btylerburton
via
6c2f527
Jin-Sun-tts
approved these changes
Apr 4, 2023
|
There are currently two open issues for upstream ckan changes that are preventing us from upgrading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
Changes:
ckanext-qadoesn't build unlesssetuptoolsis pinned to67.1.0snyk-update.pyto accommodate case sensitivity for package names (i.e.Flaskandflaskwill both match if it needs to be updated; alsoflask-???won't match and cause unintended repercussions)make update-dependencies