Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exceptions #379

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Update exceptions #379

merged 1 commit into from
Oct 20, 2021

Conversation

jbrown-xentity
Copy link
Contributor

Reformat and add exceptions

It's important to note here: .snyk file format expects the exceptions to be in the following format (note the strange double tab from '*' to the next lines). Note that if the second tab isn't there, the exception is ignored without a reason AND WITHOUT AN EXPIRATION DATE, which breaks our O&M scanning workflow of reviewing old exceptions for new fixes/mitigations (we want them to expire, so that we see if a fix is available).

If you are ever writing snyk exceptions and are unsure of the format, you can use the snyk cli to do it for you (see "Snyk Ignore")...

ignore:
  SNYK-PYTHON-SQLALCHEMY-173678:
    - '*':
        reason: >-
          No remediation path available (cannot upgrade to SQLAlchemy 1.2). 
          Reviewed group_by and order_by usage manually, all user input sanitized.
        expires: 2020-11-20T06:00:00.000Z

image

Reformat and add exceptions
@jbrown-xentity jbrown-xentity requested a review from a team October 20, 2021 20:16
@FuhuXia
Copy link
Member

FuhuXia commented Oct 20, 2021

good to know.

@FuhuXia FuhuXia merged commit 8a65d9f into fcs Oct 20, 2021
@FuhuXia FuhuXia deleted the snyk/update-exceptions branch October 20, 2021 20:25
@jbrown-xentity jbrown-xentity restored the snyk/update-exceptions branch October 20, 2021 20:46
@jbrown-xentity jbrown-xentity mentioned this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants